Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add TrackerDB Utilities category #1892

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

smalluban
Copy link
Collaborator

@smalluban smalluban commented Sep 20, 2024

Fixes #1885

  • Adds utilities category, which replaces the essential
  • Keeps the essential, as the TrackerDB must be updated when all of the platforms update to the version with the change

@philipp-classen We should clean up the essential category once we update. Please create an issue, when you will update the TrackerDB.

Also, it would be great to push the "changed" TrackerDB to the staging CDN, so we can test the change.

@@ -40,6 +41,7 @@ export const order = [
'site_analytics',
'consent',
'essential',
Copy link
Member

@chrmod chrmod Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove essential ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep it for two reasons:

  • When the extension independently gets rolled out on different platforms, there will be still TrackerDB with "essential" (because updating TrackerDB before will reintroduce the production problem from last time)
  • TrackerPreview will update independently with a delay as well (coupled to the monthly WhoTracks.me data release)

In other words, the clients needs to support utilities, but remain backward compatible to the current TrackerDB state until the changes fully propagated through the system and all platforms are running with the latest extension code.

@philipp-classen
Copy link
Member

Fixes #1885

* Adds `utilities` category, which replaces the `essential`

* Keeps the `essential`, as the TrackerDB must be updated when all of the platforms update to the version with the change

@philipp-classen We should clean up the essential category once we update. Please create an issue, when you will update the TrackerDB.

Also, it would be great to push the "changed" TrackerDB to the staging CDN, so we can test the change.

Unfortunately, is not possible with our current infrastructure. Once TrackerDB is modified, it will propagate to production. That means, first releasing the update here to all platforms and then updating TrackerDB is what I would suggest.

@smalluban
Copy link
Collaborator Author

I manually changed the name to utilities to test the UI, and everything works as expected.

@smalluban smalluban merged commit 5a80a73 into main Sep 20, 2024
2 checks passed
@smalluban smalluban deleted the fix-trackerdb-utilities branch September 20, 2024 10:46
@smalluban smalluban mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translations for new "utlity" category
3 participants